`ExceedsStackLimit` was meant to be used before running XCMs but it's being used in `FrameTransactionalProcessor` in instructions

paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK

https://polkadot.com/

1.89k stars 696 forks source link

`ExceedsStackLimit` was meant to be used before running XCMs but it's being used in `FrameTransactionalProcessor` in instructions #6199

Open franciscoaguirre opened 3 weeks ago

franciscoaguirre commented 3 weeks ago

This error had no index and was not part of the spec because it was meant to be used only before XCMs were executed, so only locally. It's being used in the FrameTransactionalProcessor which is called on a lot of instructions. This means we either need to include it in the spec or change the error to another one that is/will be in the spec.

ggwpez commented 3 weeks ago

We also match on this variant here:

https://github.com/paritytech/polkadot-sdk/blob/7ecf3f757a5d6f622309cea7f788e8a547a5dce8/polkadot/xcm/xcm-builder/src/process_xcm_message.rs#L106

The MQ pallet needs to know that it was a StackExceedsError - or rather: a transient error that may fix itself spontaneously through a user-retry but is not related to weight.