Packages for `stable2409-1` are missing

pandres95 commented 3 weeks ago

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Description of bug

I'm getting the following error (same with all the crates' versions listed below) when trying to update to stable2409-1 using psvm:

    Updating crates.io index
error: failed to select a version for the requirement `emulated-integration-tests-common = "^14.1.0"`
candidate versions found which didn't match: 14.0.0, 13.0.0, 11.0.0, ...
location searched: crates.io index
required by package `asset-hub-kusama-emulated-chain v1.0.0 (/Users/**/**/runtimes/integration-tests/emulated/chains/parachains/assets/asset-hub-kusama)`

The main reason behind this issue is that these versions seem to be missing from crates.io.

Packages affected

bp-header-chain@0.18.1
cumulus-pallet-parachain-system@0.17.1
emulated-integration-tests-common@14.1.0
pallet-message-queue@41.0.1
pallet-xcm-bridge-hub-router@0.15.1
polkadot-runtime-parachains@0.17.1
sc-network@0.45.1
staging-xcm-builder@17.0.1

Steps to reproduce

I ran the update using this command:

psvm --version stable2409-1

pvsm bumped the versions to some crates (at least 6 or 7 of them). After that, I started getting those cargo errors, just to find out that those versions didn't exist at all on crates.io. 😅

When trying to update to stable2409, it worked out perfectly fine (see runtimes#490). But failed when trying to update to stable2409-1 (here).

clangenb commented 3 weeks ago

So the patch publishing for not the most recent stable is mostly broken due to a version conflict on crates IO for the most recent stable, see https://github.com/polkadot-fellows/runtimes/issues/493#issuecomment-2433521136.

Wouldn't the solution to this be to just simply bump minor versions whenever a new stable version is released? Then the patch versions can be reserved for patches to the individual stable releases. I know this would kind a break the semantic versioning, but I think it is a very simple fix that helps us actually releasing patches on crates.io for older stable versions.

acatangiu commented 3 weeks ago

@ggwpez @EgorPopelyaev @Morganamilo this is high priority IMO, looks like we have a broken patch release mechanism potentially blocking properly delivering security fixes or other high priority fixes.

ggwpez commented 3 weeks ago

PSVM is picking the version from the branch, so it has them before they land on crates-io.

@Morganamilo do you know when sc-network for example will land? Its version is 0.45.1 on the branch but 0.45.0 on crates-io.

About the versioning conflict that @xlc highlight, I am not sure how it is currently handled. Possibly it should bump the minor version even for patch bumps, if the current patch version on crates-io is not zero. Have to ask @Morganamilo how this is currently handled.

Morganamilo commented 3 weeks ago

I'm working on fixing this now. Will try to get it fixed asap.

acatangiu commented 3 weeks ago

About the versioning conflict that @xlc highlight, I am not sure how it is currently handled. Possibly it should bump the minor version even for patch bumps, if the current patch version on crates-io is not zero. Have to ask @Morganamilo how this is currently handled.

This is the concerning part to me. It currently breaks our stable releases support.

bkchr commented 1 week ago

@Morganamilo was this solved? If yes, please close the issue.

evilrobot-01 commented 1 day ago

Seems to be the same problem for stable2407-4

psvm -v stable2407-4

❯ cargo b -r
    Updating crates.io index
error: failed to select a version for the requirement `asset-hub-westend-runtime = "^0.25.1"`

paritytech / polkadot-sdk