Web3Login button not show on mobile

paritytech / polkassembly

Polkassembly now has a new home:

https://github.com/Premiurly/polkassembly

Apache License 2.0

30 stars 37 forks source link

Web3Login button not show on mobile #1074

Closed RomeroYang closed 3 years ago

RomeroYang commented 3 years ago

https://github.com/paritytech/polkassembly/blob/8c0b7e3ccd6bd8ffa685bf2fac04b2defcff5c5b/front-end/src/components/Login/Web2Login.tsx#L104

Polkawallet App supports wallet interaction on mobile as a browser extension, but polkassembly doesn't show Web3Login on mobile screen.

niklabh commented 3 years ago

Hi Romero, would love to integrate web3 login via polkawallet. Can You provide details on how it support wallet interaction on mobile as a browser extension

RomeroYang commented 3 years ago

Polkawallet injected an event listener in the webView, and implemented polkadot.js signer methods.

The event listener: https://github.com/polkawallet-io/sdk/blob/f84879663bf924397960457666e94d826f4dde93/js_as_extension/src/index.js#L23
Send the events to host app and post response to dapp: https://github.com/polkawallet-io/sdk/blob/f84879663bf924397960457666e94d826f4dde93/js_as_extension/src/handlers.js#L35

This function works well before polkassembly hide the web3 login button.

niklabh commented 3 years ago

So i should just show the button on mobile?

RomeroYang commented 3 years ago

That's right.

RomeroYang commented 3 years ago

Or you may call web3Enable() method of @polkadot/extension-dapp to check whether js-extension exist.