search

paritytech / pr-custom-review

GitHub Action for complex pull request approval cases that are not currently supported by the Branch protection feature in GitHub.
MIT License
8 stars 4 forks source link

Configuration of include and exclude as a dictionary #135

Closed alvicsam closed 1 year ago

alvicsam commented 1 year ago

Currently I'm working on monorepo and I need to merge all rules for 3 repos, so include line can look like:

  include: ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))|^polkadot/runtime/(kusama|polkadot)/src/[^/]+\.rs$|^\.gitlab-ci\.yml|^(?!.*\.dic$|.*spellcheck\.toml$)scripts/ci/.*|^\.github/.*

Which is not human readable at all.

It would be nice to be able to configure it like this:

  include: 
    - ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))
    - ^polkadot/runtime/(kusama|polkadot)/src/[^/]+\.rs$
    - ^\.gitlab-ci\.yml
    - ^(?!.*\.dic$|.*spellcheck\.toml$)scripts/ci/.*
    - ^\.github/.*
mutantcornholio commented 1 year ago

This feature is already a part of new review-bot, which is currently in development and will replace PRCR.

More info here: https://github.com/paritytech/pr-custom-review/issues/114