paritytech / pr-custom-review

GitHub Action for complex pull request approval cases that are not currently supported by the Branch protection feature in GitHub.
MIT License
8 stars 4 forks source link

Design rules for the most relevant repositories #32

Closed joao-paulo-parity closed 2 years ago

joao-paulo-parity commented 2 years ago

Check if processbot's approval criteria + requirements can be translated to the rules according to the implementation of #31.

In doing so, provide examples of how exactly those configurations will be.

Common requirements

Locks

From https://github.com/paritytech/ci_cd/issues/233#issue-1026394650

Any PR which removes or changes

  • A line containing the emoji lock, or
  • A line which immediately follows a line containing only a comment which contains the emoji lock

must have approvals from at least one team lead as well as either the CTO or the CEO.

processbot

From merge criteria

A Pull Request needs either (meaning, only one of the following requirements needs to be fulfilled)

  • core-dev member approvals (2 for Substrate, 1 otherwise), or
  • one substrateteamleads member approval
rules:
  - name: Developers
    check_type: diff
    condition: .*
    any:
      - min_approvals: 2
        teams:
          - core-devs
      - min_approvals: 1
        teams:
          - substrateteamleads
joao-paulo-parity commented 2 years ago

Replaced by #67