paritytech / pr-custom-review

GitHub Action for complex pull request approval cases that are not currently supported by the Branch protection feature in GitHub.
MIT License
8 stars 4 forks source link

Remove ncc #8

Closed joao-paulo-parity closed 2 years ago

joao-paulo-parity commented 2 years ago

Problem: ncc is a unnecessary dependency because the compiled javascript files can just be executed directly without packaging

Solution: remove ncc and check if the action still works without packaging

joao-paulo-parity commented 2 years ago

I intuit the idea behind ncc is having the project be compiled to a single file so that it can be executed by Node directly without first having to install dependencies. This purpose needs to be documented, otherwise it looks like a useless dependency.