paritytech / pr-custom-review

GitHub Action for complex pull request approval cases that are not currently supported by the Branch protection feature in GitHub.
MIT License
8 stars 4 forks source link

Be more precise about who's missing on AndDistinctRule #88

Closed joao-paulo-parity closed 2 years ago

joao-paulo-parity commented 2 years ago

The following code can be more precise towards who's missing specifically for the not-yet-fulfilled subconditions. Currently it simply lists whoever has not approved from all subconditions, which means that it might incorrectly list someone whose approval is not relevant for the not-yet-fulfilled subconditions.

https://github.com/paritytech/pr-custom-review/blob/7f1dd983c0ab1eab409fb697e6b707e7ec371eec/src/core.ts#L475