paritytech / pr-custom-review

GitHub Action for complex pull request approval cases that are not currently supported by the Branch protection feature in GitHub.
MIT License
8 stars 4 forks source link

Improve approvals review granularity #91

Closed joao-paulo-parity closed 2 years ago

joao-paulo-parity commented 2 years ago

Review requests currently don't work optimally, as evidenced by https://github.com/paritytech/polkadot/pull/5374#event-6488509108 where the action requested more review from locks-review even though the criterion for that team had already been fulfilled.

This PR attempts to fix that case by having better granularity per-subcondition and improving the way that subconditions are processed internally.

Despite the fairly large internal rework in the core logic, the snapshots changed as expected (and minorly) which is to me a good sign of no regressions being introduced by this PR.