search

paritytech / pr-custom-review

GitHub Action for complex pull request approval cases that are not currently supported by the Branch protection feature in GitHub.
MIT License
8 stars 4 forks source link

add gitlab-ci and helm chart #93

Closed ArshamTeymouri closed 2 years ago

alvicsam commented 2 years ago

I would also add jobs that build docker images in pr (without pushing them) in order to check that they can be build. As we did here.

Also maybe it make sense to deploy staging on each commit to master and deploy production only on tag.

joao-paulo-parity commented 2 years ago

Also maybe it make sense to deploy staging on each commit to master

The vast majority of OpsTooling projects have staging deployment on stg-v* or pre-v* tags. That's what we're used to do and so I think this PR should follow suit. Auto deployment from master isn't something we're interested in having currently as corroborated by https://github.com/paritytech/substrate-matrix-faucet/pull/146 but it could be suggested as a new practice within the team. Personally I'm not interested in that and would prefer to stay with tags.