Config should not be required when not needed

paritytech / prdoc

prdoc files are YAML files following a defined schema and helping with code change documentation.

MIT License

11 stars 1 forks source link

Config should not be required when not needed #15

Closed chevdor closed 3 months ago

chevdor commented 1 year ago

Currently we load the config no matter what. That means we need to mount a volume to simply request the version which does not make much sense.

Will not work:

docker run --rm  $IMAGE --version

Will work:

docker run --rm -v $PWD:/repo $IMAGE --version

mutantcornholio commented 3 months ago

This doesn't reproduce with current version:

> prdoc --version
[2024-06-27T13:39:12Z WARN  prdoclib::config] Config not found
[2024-06-27T13:39:12Z WARN  prdoc] No config could be found, using default
prdoc v0.0.8-beta