Update fixed hash and uint

Robbepop commented 6 years ago

Major overhaul for ethereum-types and minor one for ethbloom crates.

Both got updated dependencies:

fixed-hash 0.2 => fixed-hash 0.3.0
uint 0.4 => uint 0.5.0
crunchy 0.1.6 => crunchy 0.2.1

Many hash and uint types have been removed from ethereum-types as well as some functionality and formerly deprecated items.

This should also lower compilation times of ethereum-types a lot.

TODO:

[ ] Use the ethereum-types update in parity-ethereum (huge list of dependencies)
[ ] Use the ethereum-types update in jsonrpc Also uint dependency no longer automatically generates its U256 and U512 types.

Robbepop commented 6 years ago

I completely revamped this PR. It is now a lot more aggressive. Removes many hash and uint types that are not needed.

Note: Deprecation of those items was not feasible since of the never ending warning stream resulting from it.

Robbepop commented 6 years ago

Before merging I'd like to see that parity-ethereum (and perhaps jsonrpc?) works with the new version. Maybe you tried that already though?

Haven't tried yet but will do.

Robbepop commented 6 years ago

I think checking if parity-ethereum works with the ethereum-types update isn't simply done on a day or so ...

cargo tree | grep ethereum-types

Shows us this:

│   │   ├── ethereum-types-serialize v0.2.1
│   ├── ethereum-types v0.4.0
│   │   ├── ethereum-types-serialize v0.2.1 (*)
│       ├── ethereum-types v0.4.0 (*)
│       │   ├── ethereum-types v0.4.0 (*)
│       │   ├── ethereum-types v0.4.0 (*)
│       │       ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   │   │   ├── ethereum-types v0.4.0 (*)
│   │   │   ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   │   │   ├── ethereum-types v0.4.0 (*)
│   │   │   │   ├── ethereum-types v0.4.0 (*)
│   │   │   │   ├── ethereum-types v0.4.0 (*)
│   │   │   │       ├── ethereum-types v0.4.0 (*)
│   │   │   │       │   ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   │   └── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│       ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   ├── ethereum-types v0.4.0 (*)
│   ├── ethereum-types v0.4.0 (*)
│   │   │   ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   ├── ethereum-types v0.4.0 (*)
├── ethereum-types v0.4.0 (*)
│   ├── ethereum-types v0.4.0 (*)
│   ├── ethereum-types v0.4.0 (*)
│   ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   ├── ethereum-types v0.4.0 (*)
│   │   ├── ethereum-types v0.4.0 (*)
│   ├── ethereum-types v0.4.0 (*)

Robbepop commented 6 years ago

I added a TODO list for this PR.

Robbepop commented 5 years ago

LGTM. Left one final grumble.

@dvdplm Maybe we can merge this? If we want to integrate this to parity-ethereum and jsonrpc, we'd need to first merge and publish new versions anyway.

@sorpaas We did not merge this yet because we were missing a person that wanted to take over updating of the remaining dependencies which @dvdplm suspects to be a lot. I will fix the grumble asap.

Robbepop commented 5 years ago

We should release a version 0.5 of ethereum-types after merging this.

sorpaas commented 5 years ago

@Robbepop @dvdplm Thanks! If no objections, let's merge this?

Robbepop commented 5 years ago

@Robbepop @dvdplm Thanks! If no objections, let's merge this?

You are free to merge! :)

paritytech / primitives

Update fixed hash and uint #60