paritytech / psvm

Polkadot SDK Version Manager
Other
40 stars 6 forks source link

`--check` option #10

Closed Szegoo closed 3 months ago

Szegoo commented 6 months ago

I would like to use psvm in my CI workflow to ensure the correct dependency versions are used. It would be good to add a --check flag that exits with a non-zero status code if the dependencies need updating.

SachinCoder1 commented 3 months ago

Hi @Szegoo Can you please tell more about it ? like:

I am interested on working this issue...

shawntabrizi commented 3 months ago

@SachinCoder1 I think its just having a command that tells the user that some dependencies would be updated, without actually updating them. I think PSVM only goes in and actually makes changes to files.

I am guessing this check flag would return to the user what would change without actually changing it.

I think, based on your questions, you need to familiarize yourself with this tool more.

0xsouravm commented 3 months ago

Please refer to PR #21 for the implementation of this issue. As per @Szegoo, the program exits with an error whenever it finds a dependency that doesn't match to the correct expected version.

Command: psvm --check

(similar to the --version flag usage)

Szegoo commented 3 months ago

@SachinCoder1 I think its just having a command that tells the user that some dependencies would be updated, without actually updating them. I think PSVM only goes in and actually makes changes to files.

I am guessing this check flag would return to the user what would change without actually changing it.

I think, based on your questions, you need to familiarize yourself with this tool more.

Great to see a PR, I am reviewing it now.

But yes, this is what I meant when writing the issue. This way we can use psvm in a CI workflow to ensure all the dependencies have the correct version. Exiting with an error(non zero status code) would indicate that some dependencies have incorrect versions and the CI check would fail.

shawntabrizi commented 3 months ago

closed by https://github.com/paritytech/psvm/pull/21