List and document stable versions

paritytech / psvm

Polkadot SDK Version Manager

Other

40 stars 6 forks source link

List and document stable versions #19

Open patriciobcs opened 3 months ago

patriciobcs commented 3 months ago

Following https://github.com/paritytech/psvm/pull/17

The PR allows using stable versions, so now we can list them when using psvm -l. This is useful specially for new devs that are not aware of which version to use. In the same way, It would be useful to document this new versions in the readme.

ggwpez commented 3 months ago

Yea, the latest stable could also be the default when not specifying a version.

0xsouravm commented 2 months ago

Can someone explain what this issue is about? @xlc or @ggwpez?

xlc commented 2 months ago

this is the output of psvm -l

Available versions:
- 1.1.0
- 1.2.0
- 1.3.0
- 1.4.0-staking-patch
- 1.4.0
- 1.5.0-staking-patch
- 1.5.0
- 1.6.0-staking-patch
- 1.6.0-staking-patch-changes
- 1.6.0-staking-patch-final
- 1.6.0
- 1.7.0-staking-backports
- 1.7.0-staking-backports-all
- 1.7.0
- 1.8.0-staking-patch
- 1.8.0
- 1.9.0
- 1.10.0
- 1.11.0
- 1.12.0
- 1.13.0
- 1.14.0

It should include stable2407

0xsouravm commented 2 months ago

Ahhhh Oliver mentioned this in the --orml flag PR. It could be done if the branch name is changed to release-crates-io-stable2407. Assuming all crates are updated in crates.io for this particular version.

0xsouravm commented 2 months ago

Or do the stable releases follow any particular naming convention? Could try cooking up a regex for that.

0xsouravm commented 2 months ago

@ggwpez Does release-polkadot-v1.14.0 contain the same thing as release-crates-io-v1.14.0?

0xsouravm commented 2 months ago

I was thinking of adding a --release flag to cater to the release versions of polkadot-sdk only.

ggwpez commented 2 months ago

Does release-polkadot-v1.14.0 contain the same thing as release-crates-io-v1.14.0?

The later is the crates-io and should be used here. We merged both into one for the stable releases:

A regex for these ^ should be added.

I was thinking of adding a --release flag to cater to the release versions of polkadot-sdk only.

Not sure i get what you mean?

0xsouravm commented 2 months ago

Not sure i get what you mean?

I was thinking of adding a --release flag that would parse the releases and do the same thing that --version flag does. Like psvm --release stable2407 or psvm --list --release. But then I found out it created more problems than it solved. So I dropped the idea.

0xsouravm commented 2 months ago

A regex for these ^ should be added.

Then if I parse the tags and match with a regex it should solve the problem? I will look into it.

0xsouravm commented 2 months ago

I tested this regex ^polkadot-stable\d+(-\d+)?$ It seems to do the job.

0xsouravm commented 2 months ago

Hey @ggwpez! I finished adding this feature. The code is pretty redundant so I will raise another PR for refactoring. Please review #24