Closed drahnr closed 1 year ago
Have you looked into these severe regressions?
Benchmarking parameterized reconstruct validator_count=4/novel-poly-reconstruct/7778000: Collecting 10 samples in estimated 5. parameterized reconstruct validator_count=4/novel-poly-reconstruct/7778000
time: [2.2722 ms 2.2900 ms 2.3265 ms]
change: [+416.77% +430.28% +445.18%] (p = 0.00 < 0.05)
Performance has regressed.
Benchmarking parameterized reconstruct validator_count=4/novel-poly-reconstruct/8889000: Collecting 10 samples in estimated 5. parameterized reconstruct validator_count=4/novel-poly-reconstruct/8889000
time: [3.2475 ms 3.2885 ms 3.3559 ms]
change: [+31.146% +33.674% +36.508%] (p = 0.00 < 0.05)
I think that was an artifact of rust analyzer kicking in. I have to rerun them again
Also fixes a compilation issue, besides the chores.
Benchmarking outcome (
cargo criterion
) withrustc 1.69.0 (84c898d65 2023-04-16)