paritytech / revive

Solidity compiler for PolkaVM
Apache License 2.0
38 stars 5 forks source link

Remix expects the bytecode to not be null. #51

Closed smiasojed closed 1 month ago

smiasojed commented 1 month ago

Remix expects the evm.bytecode to not be null in json output. current format:

                    "evm": {
                        "legacyAssembly": null,
                        "assembly": null,
                        "bytecode": null,
                        "deployedBytecode": {
                            "object": ""
                        },
                        "methodIdentifiers": {}
                    },

expected:

                    "evm": {
                        "legacyAssembly": null,
                        "assembly": null,
                        "bytecode": :{
                            "object": ""
                        },,
                        "deployedBytecode": {
                            "object": ""
                        },
                        "methodIdentifiers": {}
                    },
xermicus commented 1 month ago

I guess what we want to do instead is skipping serialization of any field if it isn't present. Remix expecting an empty string when it wasn't provided doesn't seem right. @smiasojed I implemented that in the cl/std-json-serialize branch, does that help?

smiasojed commented 1 month ago

it looks that I do not observe this on the main branch anymore.

smiasojed commented 1 month ago

Closing as I can not reproduce it anymore.