search

paritytech / smoldot

Alternative client for Substrate-based chains.
GNU General Public License v3.0
309 stars 74 forks source link

Backport protocol name changes and `forkId` #1955

Open tomaka opened 2 years ago

tomaka commented 2 years ago

https://github.com/paritytech/substrate/pull/10463

melekes commented 2 years ago

Another smoldot PR later should add support for forkId once Substrate/Polkadot have released a version that uses it.

Does the monthly substrate releases count? I can see that the last "stable" release was in Feb. 2021.

If the answer is yes, can I give this a shot?

tomaka commented 2 years ago

Yes, go for it!

I don't think we need to maintain backwards compatibility in smoldot, you can just overwrite /paritytech/grandpa with the replacement name.

You should be able to test if it works by running the JS demo and checking if the finalized block updates itself over time.

tomaka commented 2 years ago

cc https://github.com/paritytech/substrate/issues/10969 (I've coincidentally just noticed that when debugging some parachains stuff)

tomaka commented 2 years ago

https://github.com/paritytech/substrate/pull/11938 also now changed other protocol names.

(see also https://github.com/paritytech/polkadot/pull/5849, but it only changes protocols not implemented in smoldot at the moment)

tomaka commented 2 years ago

https://github.com/paritytech/substrate/pull/12545