VERSION should be bumped after image is published

paritytech / srtool

A fork of chevdor's srtool

MIT License

65 stars 18 forks source link

VERSION should be bumped after image is published #20

Closed chevdor closed 2 years ago

chevdor commented 3 years ago

Today, VERSION is bumped before the image is actuall pushed. This should be the other way around.

chevdor commented 3 years ago

Today in general, a new branch for a release is prepared. In this branch, the VERSION file must already be bumped so the builds are picking up the proper version. Once we merge this branch and tag it to master, the release is built and pushed to Docker hub. That means we have a 6 to 7 minutes window during which the repo says the latest version is X.Y.Z whereas this version is not yet available in Docker hub.

The window used to be 7 minutes-ish and should now be around 5:30 minutes-ish.

chevdor commented 2 years ago

Closing this issue as this is cat and mouse. The window nowadays is around 5min.