paritytech / srtool

A fork of chevdor's srtool
MIT License
64 stars 18 forks source link

Unable to use `strip` profile in cargo #40

Closed Dengjianping closed 2 years ago

Dengjianping commented 2 years ago

Hi, Is there any plan to upgrade rust to 1.59?

I was trying to use strip profile in a project, but srtool gave a error like this:

║ 🧰 Substrate Runtime Toolbox - srtool v0.9.19 🧰
  ║ - by Chevdor -
  info: using existing install for '1.57.0-x86_64-unknown-linux-gnu'
  info: override toolchain for '/build' set to '1.57.0-x86_64-unknown-linux-gnu'
  ║
  ║ 1.57.0-x86_64-unknown-linux-gnu unchanged - rustc 1.57.0 (f1edd0429 2021-11-29)
  ║
  ║ 🏗 Building calamari-runtime as release using rustc 1.57.0 (f1edd0429 2021-11-29)
  ║ ⏳ That can take a little while, be patient... subsequent builds will be faster.
  ║ Since you have to wait a little, you may want to learn more about Substrate runtimes:
  ║ https://docs.substrate.io/v3/getting-started/architecture/
  ║ error: failed to parse manifest at `/build/Cargo.toml`
  ║
  ║ Caused by:
  ║ feature `strip` is required
  ║
  ║ The package requires the Cargo feature called `strip`, but that feature is not stabilized in this version of Cargo (1.57.0 (b2e52d7ca 2021-10-21)).
  ║ Consider adding `cargo-features = ["strip"]` to the top of Cargo.toml (above the [package] table) to tell Cargo you are opting in to use this unstable feature.

strip has been stabilized in rust .159.

chevdor commented 2 years ago

Hello @Dengjianping,

I am now closing this issue as it should be fixed by the new release 0.9.19. That would be great if you could confirm with a short note here.

If you still run into issues however, feel free to re-open.