Issue with git tag - Githubissues

paritytech / srtool

A fork of chevdor's srtool

MIT License

64 stars 18 forks source link

Issue with git tag #6

Closed chevdor closed 3 years ago

chevdor commented 3 years ago

Reported by Emiel:

real    23m23.536s
user    83m12.355s
sys     1m0.776s
✨ Your Substrate WASM Runtime is ready! ✨
Summary:
  Generator  : srtool v0.9.3
  GIT commit : 2653b73ffe77ef3753b331db107986224ca5127d
  GIT tag    : v0.7.22
  GIT branch : master
  Time       : 2020-03-13T15:33:08Z
  Rustc      : rustc 1.41.0-nightly (ae1b871cc 2019-12-06)
  Size       : 1441 KB (1476455 bytes)
  Content    : 0x0061736d0100000001c2022e60037f7f...3731636320323031392d31322d303629
  Package    : kusama-runtime
  Proposal   : 0x87166c2a632dc59d07d2a81a7069f6edf89193494ad9080bf1e155134358ace9
  SHA256     : d51f7e8a2aaa148186ac9dc1058eff9b4753f4e89f26b47bcd4eb8856f53e39d
  Wasm       : ./target/srtool/release/wbuild/kusama-runtime/kusama_runtime.compact.wasm

The git tag output by the srtool is weird though. I checked out polkadot master.

chevdor commented 3 years ago

This is an old issue and I think the expectation was to see v0.7.23 instead of v0.7.22. srtool gets the tag using:

GIT_TAG=`git describe --tags --abbrev=0`

srtool itself does not run any active git commands such as fetch, pull or alike. I think the issue came from the tag not being fetched yet or even not existing yet when srtool was executed.

Closing but happy to re-open if the issue shows up with more details.