search

paritytech / ss58-registry

Registry for SS58 account types
Apache License 2.0
55 stars 150 forks source link

Add Enjin & Matrixchain #187

Closed leonardocustodio closed 1 year ago

leonardocustodio commented 1 year ago

We are moving from Efinity to Enjin Matrixchain, this PR updates it and adds Enjin Blockchain. We've already changed our slip044 as well: https://github.com/satoshilabs/slips/pull/1598

SBalaguer commented 1 year ago

Given the intended nature of the Enjin Blockchain ecosystem's growth, I believe that presently the best course of action is to rather fork this registry and keep one that fully suits your needs, current and future.

I think this stands too for PolkadotJS, so I'll be commenting that on here too.

leonardocustodio commented 1 year ago

Hello @SBalaguer, Would you mind to explain what is the "intended nature of the Enjin Blockchain ecosystem growth"? And why is it different from the various standalone chains that are also here and are not parachains of polkadot? Regards

SBalaguer commented 1 year ago

My point is that with the objective of the Enjin Blockchain and the consequent Matrixchain explained on it's whitepaper, the best course of action is to fork this registry and keep a list of the top-level blockchain with all the subsequent connected chains (like Enjin Matrixchain and whatever others might come in the future). This predicted growth future is what makes the essence of Enjin Blockchain and Enjin Matrixchain different than any other solochain, and that it's why forking will be most probably best to suit your needs, current and future.

leonardocustodio commented 1 year ago

I understand your point but I don't really agree with it. This is a registry of SS58 prefixes it basically maps any substrate chain that uses SS58 as a standard to the prefix that it uses to make the lives of other developers easier. There is no point in making a fork of a registry it would do the exact opposite, making the life of developers harder. Also, it doesn't say in the docs, nor the repo, nor anywhere. That relaychains and parachains of other relaychains cannot be registered here. I mean like I said a "ss58registry" not a "polkadot relaychain registry" as we can see for the lots of standalone chains that we have here. And even by the readme

A list of known SS58 account types as an enum, typically used by the Polkadot, Kusama or Substrate ecosystems.

We are a substrate ecosystem, so, I would like your reconsideration, if possible.

Bradez commented 1 year ago

@SBalaguer I'm not sure that I would agree with your statement here.

The purpose of this repository is to act as a central repository for a list of known SS58 account types. @leonardocustodio, on behalf of Enjin, is submitting additional SS58 account types that are in-fact in-use and known. This is a contribution to the ever growing list of known SS58 account types.

This is not a registry that's exclusive to Polkadot or Kusama, and treating it as such is counter-productive to the growth of Substrate-based ecosystems as a whole. The README.md of the repository indicates as such:

A list of known SS58 account types as an enum, typically used by the Polkadot, Kusama or Substrate ecosystems.

There is no other indication that Substrate ecosystems outside of Polkadot or Kusama are prohibited, and so closing this under that pretence is otherwise inappropriate.

leonardocustodio commented 1 year ago

As we don't get any answer, @gavofyork, can you confirm to us that's the official parity decision? To not operate a ss58 registry without bias, unlike slip044 where we don't see this kind of stuff?

bkchr commented 1 year ago

Hey, I would be open to approve and merge your pull request. I would just have one requirement before doing this, please open up any code that was forked from us. The node side is GPL3 licensed and requires to open up any changes any way. We are believing in open source and this is also better for the Substrate ecosystem. In the future you should then also help us to identify actual builders in your ecosystem to prevent that the registry is spammed.

leonardocustodio commented 1 year ago

Hello @bkchr, thank you for your response. If you don't mind I would like to make a comment about the following point as I'm not sure you are aware of our work.

We are believing in open source and this is also better for the Substrate ecosystem.

Enjin is very committed to the open-source community and we also believe we can do great things together. Every single project that I work on forked or not is open-source and was done in a way that is generic enough for any substrate chain to integrate with it. Here is a list of a few of them:

bkchr commented 1 year ago

@leonardocustodio where can I find your actual Substrate chain?