`/staking-payouts` should be updated for `staking.eraStakersClipped` deprecation.

paritytech / substrate-api-sidecar

REST service that makes it easy to interact with blockchain nodes built using Substrate's FRAME framework.

https://paritytech.github.io/substrate-api-sidecar/dist/

GNU General Public License v3.0

244 stars 151 forks source link

`/staking-payouts` should be updated for `staking.eraStakersClipped` deprecation. #1411

Open TarikGul opened 6 months ago

TarikGul commented 6 months ago

Given https://github.com/polkadot-js/api/issues/5771 there is change happening to eraStakersClipped that is going to be an internal breaking change. It is being replaced by ErasStakersPaged, and ErasStakersOverview.

The PR linked has all the information necessary to the original PR, and forum link describing the changes.

Imod7 commented 4 months ago

Pending Items

In addition to the changes in the linked PR, we need to:

Add tests for eras after the runtime upgrade . Cover cases :
- for validator account with own exposure == 0 or not
- if possible find an example with page != 0
Add tracking issue to remove completely the erasStakersClipped call as soon as it is removed from storage. The progress can be checked in this issue.