Input validation - Githubissues

paritytech / substrate-telemetry

Polkadot Telemetry service

GNU General Public License v3.0

312 stars 206 forks source link

Input validation #13

Open maciejhirsz opened 6 years ago

maciejhirsz commented 6 years ago

Limit node name to 64 utf16 codepoints, or unicode characters.
Make sure all values make sense (hashes are actually hashes, number values are correct numbers).
Have some heuristics to kick misbehaving nodes.

chevdor commented 6 years ago

Even less with 32?

the screenshot below shows a 41 chars long name:

maciejhirsz commented 6 years ago

I'll limit the display with CSS to fit whatever resolution people might have (add ellipsis at the end and full name on hover). The character limit is more of the backend.

chevdor commented 6 years ago

OK that will work. I was about to suggest limiting the height of the table cells but with your fix, that will not longer needed. Looking forward for that one.

Since the number of nodes keeps increasing, you may want to condense the table though, so we can fit more on a screen :)

chevdor commented 6 years ago

FYI, the backend fix has been merged but it will take a bit of time for all the nodes to update. See https://github.com/paritytech/polkadot/pull/395

ltfschoen commented 6 years ago

I think we also need a profanity filter on the Polkadot Node names