Open grenade opened 2 years ago
You are right the docs are not good here. It is the chain id and this should be clarified.
That said, I suspect that using chain ID isn't good enough though as there's nothing stopping two chains from having the same name (and sadly it's not even uncommon for this to occur). The fix for that would be to pass in the genesis hash, which is a bit unwieldy for users.
How about we do this:
--denylist
accepts both a chain id (possibly ambiguous) and a genesis hash (0x
-prefixed hex string)"
, '
etc allowed (exits with error)From our internal chat, Telemetry is only sent the genesis hash and chain name (the thing that can contain spaces).
Soo, I'd be happy with --denylist
accepting either genesis hash or chain name (the space separated pretty name), and tweaking the docs to make usage clear.
telemetry_core --help
states that--denylist
is a "Space delimited list of the names of chains that are not allowed to connect to telemetry. Case sensitive".this leaves ambiguity around how to specify chain names that contain spaces. presumably:
would probably work, but begs the questions:
i currently just specify both the name and id separated by spaces in the hope that it gets figured out internally but i would like to understand what is actually required.
eg: here's how our terraform config for our production telemetry filters out testnet chains: