search

paritytech / substrate-telemetry

Polkadot Telemetry service
GNU General Public License v3.0
307 stars 205 forks source link

Expose node IP addresses via feed #490

Closed jsdw closed 2 years ago

jsdw commented 2 years ago

A recent contribution switched telemetry from using third party location services to an internal database.

This exposed an issue whereby the 1kv program using our location strings to help score nodes based on their location. The location DB will be more likely to return values, just because it doesn't exceed rate limits and such, butmay adversely impact that scoring.

So, let's add a CLI flag that we can start telemetry_core with to return IP addresses in the node information that comes back in the UI feed. If not provided, the address will be None.

The IP addresses will never be displayed by the feed, but this allows 1kv tooling to pick it up.

In the future we'd like a proper API for third party tooling to use to access telemetry data, but this will do the job for now, and allow the new location DB to be released while hopefully avoiding said impact.

/cc @wpank

PierreBesson commented 2 years ago

Would it be possible to show the IP in the Telemetry UI when it is available ?