search

paritytech / substrate-telemetry

Polkadot Telemetry service
GNU General Public License v3.0
299 stars 209 forks source link

Adding gitspiegel-trigger workflow #559

Closed mutantcornholio closed 7 months ago

mutantcornholio commented 8 months ago

Using a workflow to trigger mirroring instead of a webhook allows us to reuse "Approving workflow runs from public forks" GitHub feature to somewhat protect us from malicious PRs

mutantcornholio commented 7 months ago

The first attept to use a workflow to protect GitLab CI from untrusted contributors failed, because GitHub doesn't pass secrets to workflows for PRs that originate from forks.

This uses a different approach: instead of triggerring gitspiegel API directly from the workflow, we're just spawning an empty workflow with a specific path, and gitspiegel listens for workflow_run event to start mirroring.

The idea is the same: for the first-time contributors, running workflows would require manual aciton and that would block mirroring. But this time, we don't need any secrets to make it work.