search

paritytech / substrate-up

Scripts for working with new Substrate projects
Apache License 2.0
67 stars 21 forks source link

Reorder the renaming in the script #23

Closed shawntabrizi closed 5 years ago

shawntabrizi commented 5 years ago

This is a half-baked patch to solve a common scenario where people name their project substrate-node-template, but I would prefer a solution that makes it so that we are only replace one, pretty unique string, rather than doing 2 different string renames.

Fixes https://github.com/paritytech/substrate-up/issues/22

@xlc

bkchr commented 5 years ago

@shawntabrizi you can just safely remove template-node, as this was the old name of the node-template and is not used anymore.

xlc commented 5 years ago

Maybe we should be using a real templating library instead of naive search & replace?

shawntabrizi commented 5 years ago

@bkchr there are still places where template-node is used:

image

So removal of those lines must accompany an update to the node-template, which I can do.

@xlc I am not so familiar in that space. Do you have a suggestion?

bkchr commented 5 years ago

Yes, you can create a pr for this to substrate.