search

paritytech / substrate-up

Scripts for working with new Substrate projects
Apache License 2.0
67 stars 21 forks source link

Update substrate-node-new to use latest 1.0 tag when it is created #28

Closed xlc closed 5 years ago

xlc commented 5 years ago

I believe currently it is using the substrate master which is not stable https://github.com/paritytech/substrate-up/blob/c33875f7079f13c5270664cf603ac1f3fd3d66a1/substrate-node-new#L42

When new 1.0 tag is been created, the above line should be changed to use the tagged release instead.

https://github.com/paritytech/substrate/issues/2275#issuecomment-483179984

shawntabrizi commented 5 years ago

A PR for this change, when ready, can be found here: https://github.com/paritytech/substrate-up/pull/30

gautamdhameja commented 5 years ago

I guess this issue can be closed now as the said PR (https://github.com/paritytech/substrate-up/pull/30) is merged. @shawntabrizi ?