search

paritytech / substrate-website

BSD Zero Clause License
3 stars 13 forks source link

Update seminars page #221

Closed sacha-l closed 2 years ago

sacha-l commented 2 years ago

I've updated the page to add a few links and did a little copy editing.

@je-boska: you'll notice I removed the "Past seminar" page and just put the YT link. I hope you're ok with this as a temporary fix while we wait on #209.

netlify[bot] commented 2 years ago

Deploy Preview for substrate-website ready!

Name Link
Latest commit 23947f9f2c827dfbad5d098675a12211562bcd87
Latest deploy log https://app.netlify.com/sites/substrate-website/deploys/624f134651426e00087f5b28
Deploy Preview https://deploy-preview-221--substrate-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

je-boska commented 2 years ago

I don't have merge privileges, so I'll check with someone who does.

Are these changes reflected in the Figma spec? I know we're a little off there by now, but since we're actively working on a feature relating to this, it would be be best if the content is aligned everywhere.

The reason why it's not building is possibly the external links, which I can fix.

sacha-l commented 2 years ago

These changes aren't reflected as far as I know. This is an interim fix for the "upcoming seminars" issue. In addition, adding a CTA for people to use a new way to propose new seminars.

It would be great to apply them sooner than later if we can, right now what we have live is misleading and potentially confusing.

4www commented 2 years ago

Hello, also noticing that you are linking to a repository on your private github profile.

This seems to me like a bad practice, and a potential security vulnerability.

Would you mind to elaborate on what is the context of your PR and the associated changes?

Thanks in advance.

sacha-l commented 2 years ago

Anything blocking this ? I update the link to the Github repo which was previously my personal one.