paritytech / substrate-website

BSD Zero Clause License
3 stars 13 forks source link

*Docs launch - to be merged with PR # 1130 on substrate-docs #254

Closed jonnysmillie closed 2 years ago

jonnysmillie commented 2 years ago

add developers page, add playground page, move smart-contracts page, add required components, change links, add assets, alter some styles

https://github.com/substrate-developer-hub/substrate-docs/pull/1130

netlify[bot] commented 2 years ago

Deploy Preview for substrate-website ready!

Name Link
Latest commit 5d781459d35b68fccbbd25bd1205a9524786acbe
Latest deploy log https://app.netlify.com/sites/substrate-website/deploys/62b06d516d06762ae526bee9
Deploy Preview https://deploy-preview-254--substrate-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rcos7 commented 2 years ago

Probably a design thing but the animations on these cards make me think they're clickable but its only the button thats clickable. Feels a bit weird to me

Screenshot 2022-06-16 at 13 10 25
rcos7 commented 2 years ago

Same with the CommunityCard. This one feels even weirder with the pointer cursor

Screenshot 2022-06-16 at 13 15 19
jonnysmillie commented 2 years ago

@rcos7 I agree regarding the ambiguous nature of the hover effects and animation of these card elements, however, that is how they were implemented and I think changes to these styles would be site wide and therefore beyond the scope of this PR. Perhaps we can address this soon in another PR.

rcos7 commented 2 years ago

@rcos7 I agree regarding the ambiguous nature of the hover effects and animation of these card elements, however, that is how they were implemented and I think changes to these styles would be site wide and therefore beyond the scope of this PR. Perhaps we can address this soon in another PR.

Ok cool. Would be good to mention it to design just so they're aware of the weird UX