paritytech / substrate-website

BSD Zero Clause License
3 stars 13 forks source link

Add a mobile announcement banner about Polkadot SDK #350

Closed rzadp closed 1 month ago

rzadp commented 2 months ago

Here, we added an announcement banner about Polkadot SDK to the website. However it only shows up on desktop resolutions.

This introduces the same information as a form of a top announcement banner, visible on mobile resolutions.

https://github.com/user-attachments/assets/0a532e7c-3afd-4587-be80-466010047a2a

netlify[bot] commented 2 months ago

Deploy Preview for substrate-website ready!

Name Link
Latest commit a446345e6d675d5562c47b53e0f28f4662a9a6a2
Latest deploy log https://app.netlify.com/sites/substrate-website/deploys/66e4229bbc218600080586e3
Deploy Preview https://deploy-preview-350--substrate-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rzadp commented 1 month ago

For some reason the feature does not show on the Netlify deply preview, I don't know why. Could be something with caching dependencies?

It shows up locally.

mordamax commented 1 month ago

For some reason the feature does not show on the Netlify deply preview, I don't know why. Could be something with caching dependencies?

It shows up locally.

did you try to build locally with production mode?

i can see it in sources though, but not in the content of the pages layout

image

rzadp commented 1 month ago

did you try to build locally with production mode?

I did, same result.

It looks like it doesn't use updated version of git submodule gatsby-plugin-substrate

rzadp commented 1 month ago

It worked now after this: https://github.com/paritytech/substrate-website/pull/350/commits/516d26cd5486409e6a1a8d4dccca8a67ccca5065

It was also mentioned here.

rzadp commented 1 month ago

After triggering the cache invalidation, it appears now.

@mordamax Can you review it now?

Not sure it makes sense to dig deeper into this cache problem, since the website is being decommissioned.