paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Rename default filtering to avoid misuse #10135

Open nuke-web3 opened 3 years ago

nuke-web3 commented 3 years ago

Many users have been confused in the context of about Everything vs. Nothing - what does this mean in the filtering context? Do you allow Everything or block Everything? This was a security issue amended in the template:

        // Was `Everything`, created security issues on XCM filters! 
    type XcmReserveTransferFilter = Nothing;

To resolve this ambiguity, I propose we go back to the terms AllowAll and DenyAll that are much more concretely understood.

leonardocustodio commented 2 years ago

@NukeManDan there you go, hope it helps.

Regards,

deepink-mas commented 1 year ago

How about fixing by a reformulation of Filter to Allow:

type XcmReserveTransferAllow = Nothing;