search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

asset-conversion pallet: No need for AssetBalanceOf #14325

Closed gilescope closed 1 year ago

gilescope commented 1 year ago

Instead of AssetBalanceOf<T> we can just reference T::AssetBalance. Less voodoo.

No other changes contained in this PR.

bkchr commented 1 year ago

I dont think the current code is entirely correct.

Config item Currency for example restrains the Balance of InspectFungible, but not of MutateFungible. I am not sure if this can lead to a situation where a type with incompatible InspectFungible and MutateFungible could be configured, but it might. Same for Assets and PoolAssets.

MutableFungible has InspectFungable as super trait.

gilescope commented 1 year ago

bot merge