search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Use default config trait in mock runtimes #14336

Closed ggwpez closed 1 year ago

ggwpez commented 1 year ago

Would be good if we start using the default config trait from https://github.com/paritytech/substrate/pull/13454 to ensure that we covered most use-cases. For example in all mock.rs files on frame_system and maybe also pallet-balances.
Now we can still make some adjustments before more downstream projects start using it.
cc @juangirini

(This brings me to the idea that we could have a nightly or unstable module in frame-support, where we throw stuff in that has not been battle tested.)

kianenigma commented 1 year ago

Isn't this one item in https://github.com/paritytech/polkadot-sdk/issues/171?

juangirini commented 1 year ago

It looks like a good candidate for a sub issue of the tracking one

kianenigma commented 1 year ago

Still seems like the list of pallets I have in https://github.com/paritytech/substrate/pull/14453 :D

ggwpez commented 1 year ago

yea, duplicate.