search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

inspect role for nonfungibles_v2 #14341

Closed mutobui closed 1 year ago

mutobui commented 1 year ago

Add an interface to read-only the role of pallet-nfts

Since using pallet-nfts, we need a way to read the NFT's role to implement other functions.

cla-bot-2021[bot] commented 1 year ago

User @mutobui, please sign the CLA here.

jsidorenko commented 1 year ago

bot fmt

command-bot[bot] commented 1 year ago

@jsidorenko https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2970549 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-a8daedbe-f102-47ec-a6df-08e44aa02714 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] commented 1 year ago

@jsidorenko Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2970549 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2970549/artifacts/download.

jsidorenko commented 1 year ago

Code-wise, everything looks good! Pls update the description and change the doc comments as per the suggestions

jsidorenko commented 1 year ago

Pls try to merge the master branch to make the CI happy. But I would guess that we need to get that PR: https://github.com/paritytech/substrate/pull/14424 merged into master first.

ggwpez commented 1 year ago

bot merge