Closed Szegoo closed 1 year ago
@liamaharon Could you review this?
Can you add your address for tip cc @juangirini?
bot fmt
@juangirini https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3007981 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh"
. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.
Comment bot cancel 3-74db7a7e-7bf8-44c2-bfaf-70e8229bb829
to cancel this command or bot cancel
to cancel all commands in this pull request.
@juangirini Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh"
has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3007981 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3007981/artifacts/download.
/tip small
@juangirini A small (2 KSM) tip was successfully submitted for @Szegoo (DfqY6XQUSETTszBQ1juocTcG9iiDoXhvq1CoVadBSUqTGJS on kusama).
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fkusama-rpc.polkadot.io#/referenda
bot rebase
Rebased
@liamaharon Don't merge this yet :P I am working on incorporating --at
into the tests.
@liamaharon Don't merge this yet :P I am working on incorporating
--at
into the tests.
Please let us know once ready for final review.
@liamaharon I realised that the problem I encountered was not in the block_hash
function. It seems like there isn't an issue, but I am a bit confused.
In the execute_block
function why don't we execute the block we specified with the --at
option? The code will do execute_block
for the next block.
Hmm.. Intuitively I would also expect execute_block
to re-execute the block at
rather than at + 1
. @kianenigma do you remember if this behavior is intentional?
Needs to merge master to make the CI happy.
Going to merge this. We can investigate afterwards if this --at
needs a fix. This way we already have some tests.
bot merge
Waiting for commit status.
/tip small
@kianenigma A small (2 KSM) tip was successfully submitted for @Szegoo (DfqY6XQUSETTszBQ1juocTcG9iiDoXhvq1CoVadBSUqTGJS on kusama).
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fkusama-rpc.polkadot.io#/referenda
This PR adds tests for the following
try-runtime
commands:execute-block
create-snapshot
Part of: #13796
Kusama address: DfqY6XQUSETTszBQ1juocTcG9iiDoXhvq1CoVadBSUqTGJS