[pallet_collective] set_members Extrinsic Allows Arbitrary 'prime' Argument

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Motivation

The motivation behind filing this issue is to address problematic behaviour in the pallet_collective module of the FRAME pallets. The current implementation of the set_members extrinsic allows for an arbitrary value to be passed as the prime argument, despite its intended purpose of representing one of the members in the new_members argument. This behaviour deviates from the expected functionality.

Request

The request is to modify the set_members extrinsic in the pallet_collective module of the FRAME pallets to enforce the intended usage of the prime argument.

Solution

To address this issue, I propose that the prime argument should be restricted to accepting only one of the accounts listed in the new_members argument. This modification will ensure that the set_members extrinsic functions as intended, allowing for correct and secure updates to the collective membership. I would be happy to raise a PR to fix this issue.

Are you willing to help with this request?

Yes!

paritytech / substrate