paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Fix for `pallet_assets::create` benchmark #14384

Closed bkontur closed 1 year ago

bkontur commented 1 year ago

Benchmark for create should use origin returned by T::CreateOrigin::try_successful_origin instead of SystemOrigin::Signed(caller).

E.g. ForeignCreators does not work with that, because it expects PalletXcm::Origin which is correctly returned from T::CreateOrigin but then caller is wrapped with SystemOrigin::signed(caller) which does not pass EnsureXcm validation here

Fixes: https://github.com/paritytech/cumulus/issues/2727

ggwpez commented 1 year ago

bot bench $ pallet dev pallet-assets

command-bot[bot] commented 1 year ago

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2994835 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet-assets. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-a82b9dd8-5718-4f71-afce-c523aae52400 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] commented 1 year ago

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet-assets has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2994835 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2994835/artifacts/download.

ggwpez commented 1 year ago

bot merge