paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Deprecate RewardDestination::Controller from staking #14409

Closed rossbulat closed 1 year ago

rossbulat commented 1 year ago

Deprecating this PR In favour of a lazy migration


This PR removes the RewardDestination::Controller variant as a continuation of the controller account deprecation effort for staking.

Included is a migration that updates existing Controller payees to Account(controller).

Controller Payees to Migrate

The migration in this PR migrates every payee record, as Controller was index 3 and removing it therefore changes the encoding of the subsequent variants. Nevertheless, the actual Controller reward destinations that exist on the networks are as follows:

Polkadot: 706 Kusama: 571 Last updated: 07/07/2023 21:35 GMT+1

stale[bot] commented 1 year ago

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

rossbulat commented 1 year ago

bot rebase

paritytech-processbot[bot] commented 1 year ago

Error: Command 'Command { std: cd "/storage/repositories/substrate" && "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

rossbulat commented 1 year ago

Closing in favour of https://github.com/paritytech/substrate/pull/14451/.