paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

suppress unused warning in kitchensink example #14417

Closed sam0x17 closed 1 year ago

sam0x17 commented 1 year ago

This fixes the unused error for new_test_ext() in the kitchensink example when running cargo test with no arguments

Happy to address this some other way like with a cfg flag if appropriate.

Fixes the unused error for new_test_ext() when compiling cargo test by adding a test that uses it

sam0x17 commented 1 year ago

This also raises the question: do we not check that cargo test with no arguments has no warnings in CI?

gupnik commented 1 year ago

bot fmt

command-bot[bot] commented 1 year ago

@gupnik https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3045422 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-ff4704ef-090b-4811-a343-3e7127216169 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] commented 1 year ago

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3045422 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3045422/artifacts/download.