search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Unify `SyncMode` data structures under one #14465

Closed nazar-pc closed 1 year ago

nazar-pc commented 1 year ago

There were two of the same, but slightly different enums. For some other changes I'm planning to do it is helpful if they are the same.

Light sync mode was removed as it is not used for some time. SyncMode::Fast is SyncMode::LightState now the way it was in one of the data structures (and is a better name IMHO).

When creating this PR I noticed there is a third SyncMode in sc-cli, I didn't touch it.

nazar-pc commented 1 year ago

Initial change was a bit incorrect, after which I noticed even more things can be removed with light sync mode gone