This PR forces pools to not have a commission configured above GlobalMaxCommission. The current code allows users to set a current commission and max commission above GlobalMaxCommission, without any error or warning when doing so.
This PR explicitly fails the set_commission_current and set_max_commission calls if the provided commission is more than GlobalMaxCommission.
[x] Add a check in try_update_current to not be above GlobalMaxCommission.
[x] Add a check in try_update_max to not be above GlobalMaxCommission.
[x] Amend global_max_caps_max_commission_payout test to account for try_update_current check.
[x] Amend set_commission_max_works_with_error_tests for try_update_max check.
rossbulat
commented
1 year ago
This PR forces pools to not have a commission configured above
GlobalMaxCommission. The current code allows users to set a current commission and max commission aboveGlobalMaxCommission, without any error or warning when doing so.This PR explicitly fails the
set_commission_currentandset_max_commissioncalls if the provided commission is more thanGlobalMaxCommission.try_update_currentto not be aboveGlobalMaxCommission.try_update_maxto not be aboveGlobalMaxCommission.global_max_caps_max_commission_payouttest to account fortry_update_currentcheck.set_commission_max_works_with_error_testsfortry_update_maxcheck.