search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Make `Notifications` poll `ProtocolController`s #14509

Closed dmitry-markin closed 1 year ago

dmitry-markin commented 1 year ago

This PR restores the practice of polling slot allocation logic by Notifications and reporting peer connection events via sync calls instead of async channels in order to make ProtocolController less susceptible to state inconsistency issues.

paritytech-cicd-pr commented 1 year ago

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3139669

stale[bot] commented 1 year ago

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

dmitry-markin commented 1 year ago

Closing as we don't plan to merge this now. We might want to revisit the slot allocation implementation in the future though.