search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

remove redundant arm #14529

Closed deepink-mas closed 1 year ago

deepink-mas commented 1 year ago

remove redundant arm

ggwpez commented 1 year ago

I think i tried to remove that duplicate ; branch before, but it did not work. Lets see if the CI compiles it this time...

deepink-mas commented 1 year ago

Ah, I see that there is indeed a failure due to a local ambiguity (with --features=runtime-benchmarks), which seems to happen because tt can apparently match a semi-colon.

Can we just require the semi-colon to be present? Or is that an externally visible change?

deepink-mas commented 1 year ago

I removed that semi-colon deduplication stuff.

paritytech-cicd-pr commented 1 year ago

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-check-each-crate-macos Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3169094

sam0x17 commented 1 year ago

looks like some stuff still failing

ggwpez commented 1 year ago

Can we just require the semi-colon to be present? Or is that an externally visible change?

We want it to work with and without semi-colon.

deepink-mas commented 1 year ago

Can we just require the semi-colon to be present? Or is that an externally visible change?

We want it to work with and without semi-colon.

Yeah, that's what I figured :)

deepink-mas commented 1 year ago

looks like some stuff still failing

Yeah, I'll park this for now...