paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Re-add deprecated `--execution` arg on `benchmark pallet` #14567

Closed ggwpez closed 1 year ago

ggwpez commented 1 year ago

Changes:

bkchr commented 1 year ago

Why bring it back?

I mean yes, I should not have removed it directly, but now this happened. This is also more a dev centric command and not really used by "users".

ggwpez commented 1 year ago

Why bring it back?

I mean yes, I should not have removed it directly, but now this happened. This is also more a dev centric command and not really used by "users".

Its probably used in automation (also by downstream teams). So I think having some grace period is some nicer experience.
But its surely not really necessary, so I can also close again 🤷‍♂️

bkchr commented 1 year ago

Why bring it back? I mean yes, I should not have removed it directly, but now this happened. This is also more a dev centric command and not really used by "users".

Its probably used in automation (also by downstream teams). So I think having some grace period is some nicer experience. But its surely not really necessary, so I can also close again man_shrugging

Yeah, IDK. Then let's keep it, but we don't need this in all the tests.

ggwpez commented 1 year ago

bot merge

paritytech-processbot[bot] commented 1 year ago

Waiting for commit status.