search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

wrong name regex to filter url when provide --name=www as parameter in cli #14575

Closed atenjin closed 1 year ago

atenjin commented 1 year ago

close #14574

In this pr, we just filter http:// https:// prefix in the string, not including word www

michalkucharczyk commented 1 year ago

Technically URLs don't necessarily have to be for HTTP(S), so maybe we should just disallow URLs for any protocol?

had the same thought

atenjin commented 1 year ago

@michalkucharczyk hey another thing, can this hotfix pr cherry pick to polkadot-0.9.43 branch? oh maybe this contains in polkadotv1.0.0 is also ok

bkchr commented 1 year ago

@atenjin I don't see that this is a critical change that needs to be backported

atenjin commented 1 year ago

@bkchr sorry in our project, we are using this substrate branch in our chain, we meet this bug in our running service. We can not ensure the time for the next polkadot version, so if this can be moved to that branch is more better

bkchr commented 1 year ago

Just don't remove the www from the name of your node. These names are only required for telemetry and nothing else and telemetry isn't important.