paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

removed `without_storage_info` from `pallet-collective` #14585

Open muraca opened 1 year ago

muraca commented 1 year ago

Closes paritytech/polkadot-sdk#167

Cumulus companion: cumulus#2884 here

Polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp

muraca commented 1 year ago

@ggwpez could you please run benchmarks?

juangirini commented 1 year ago

bot bench $ pallet dev pallet_collective

command-bot[bot] commented 1 year ago

@juangirini https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3198277 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_collective. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-a09aeb1d-329f-4044-8110-364b21872a93 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] commented 1 year ago

@juangirini Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_collective has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3198277 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3198277/artifacts/download.

paritytech-cicd-pr commented 1 year ago

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-check-benches Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3203848

juangirini commented 1 year ago

/tip small

substrate-tip-bot[bot] commented 1 year ago

@juangirini A small (20 DOT) tip was successfully submitted for @muraca (12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/referenda tip

stale[bot] commented 1 year ago

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.