paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

client: fix invalid node name pattern regex #14593

Closed andresilva closed 1 year ago

andresilva commented 1 year ago

See https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3206771.

polkadot companion: https://github.com/paritytech/polkadot/pull/7484

(the companion above is fake, needed to unlock ci)

michalkucharczyk commented 1 year ago

Are other protocols' prefixes fine (like 'wss://')?

bkchr commented 1 year ago

Are other protocols' prefixes fine (like 'wss://')?

In the end this entire check here is useless anyway, because everyone could send whatever they want to the telemetry backend. So, this here is just some kind of sanity check.

bkchr commented 1 year ago

bot merge force