paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Runtime: avoid duplication and test all signature #14663

Closed ashWhiteHat closed 1 year ago

ashWhiteHat commented 1 year ago

Description

I found signature test code following duplication. https://github.com/paritytech/substrate/blob/fbdf00888d778bab4d31a8938de7bed7e53d2d53/primitives/runtime/src/traits.rs#L2424-L2425

ecdsa error case is not tested and ed25519/sr25519 cases are not tested. I added following test cases

Checklist

ashWhiteHat commented 1 year ago

Hi there I would like to add label A0-please_review but it seems I can't

ashWhiteHat commented 1 year ago

I also found following std feature duplication. https://github.com/paritytech/substrate/blob/fbdf00888d778bab4d31a8938de7bed7e53d2d53/test-utils/runtime/Cargo.toml#L85-LL86