paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

Contracts: Ensure latest migration match pallet_version #14676

Closed pgherveou closed 1 year ago

pgherveou commented 1 year ago

bot rebase

paritytech-processbot[bot] commented 1 year ago

Rebased

athei commented 1 year ago

There's already code in every pallets post_migrate hook (which are now run as part of CI) to ensure this. Does this provide anything extra on top of that?

Yes. The hook you mentioned checks that we did not forget a migration. This prevents the inverse case where we added a migration but forgot to bump the pallet version.

pgherveou commented 1 year ago

bot merge