search

paritytech / substrate

Substrate: The platform for blockchain innovators
Apache License 2.0
8.39k stars 2.65k forks source link

feature flag to disable consequential Gov V1 hooks #14708

Closed liamaharon closed 1 year ago

liamaharon commented 1 year ago

https://github.com/paritytech/polkadot/pull/7314 requires us to temporarily restore Gov V1 pallets to the runtime.

We need the pallets to be entirely benign.

We can disable Calls using exclude_parts {Call}, but still need to prevent hooks from being called.

It was agreed during the last FRAME team call to add a feature flag which would disable hooks we don't want to run. There may be better approaches to disabling hooks (such as creating a new part we can use in exclude_parts, but that would likely take a long time to implement and unlocking the Gov V1 funds is time sensitive.

liamaharon commented 1 year ago

Going to spend more time trying to remove pallets from construct_runtime! as suggested by Basti. Converting this to a draft in the meantime.

liamaharon commented 1 year ago

Superseded by approach laid out in https://github.com/paritytech/substrate/pull/14773